Review Request 118977: KSMServer: Do not autostart files

Aleix Pol Gonzalez aleixpol at kde.org
Thu Jul 3 00:18:35 UTC 2014


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/118977/#review61517
-----------------------------------------------------------

Ship it!


Hi, I had it applied and I pushed because I thought it was another commit, then I realized and I Ctrl+C. It didn't get pushed but now I see this e-mail got sent. Sorry about the noise.

FWIW, the patch worked fine.

- Aleix Pol Gonzalez


On July 3, 2014, 12:14 a.m., Vishesh Handa wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.org/r/118977/
> -----------------------------------------------------------
> 
> (Updated July 3, 2014, 12:14 a.m.)
> 
> 
> Review request for Plasma and Àlex Fiestas.
> 
> 
> Bugs: 335878
>     https://bugs.kde.org/show_bug.cgi?id=335878
> 
> 
> Repository: plasma-workspace
> 
> 
> Description
> -------
> 
>     KSMServer: Do not autostart files
> 
>     Currently KLauncher is responsible for starting all of the autostart
>     files. It intelligently starts only the files which should be started in
>     the KDE environment.
> 
>     Once this is done, KLauncher then decides to also start all the files
>     in the autostart folder, but does that without checking which should be
>     started. I'm not sure why both KSMServer and KLauncher are overlaping
>     and doing the same thing. But it seems that KLauncher is the correct
>     place to do this. Specially since ksmserver uses kioclient5 in order to
>     start the applications.
> 
>     BUG: 335878
> 
> 
> Diffs
> -----
> 
>   ksmserver/server.h 3d19118 
>   ksmserver/startup.cpp 11cc968 
> 
> Diff: https://git.reviewboard.kde.org/r/118977/diff/
> 
> 
> Testing
> -------
> 
> Applications are now only started once.
> 
> 
> Thanks,
> 
> Vishesh Handa
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/plasma-devel/attachments/20140703/d6ca180a/attachment.html>


More information about the Plasma-devel mailing list