Review Request 119092: Add "sudo" to the make install command in the README file
R.Harish Navnit
harishnavnit at gmail.com
Wed Jul 2 22:59:02 UTC 2014
> On July 2, 2014, 10:28 p.m., Mark Gaiser wrote:
> > err.. What is done in that readme is bad practice. It should advertise compiling into a prefix the user has permissions. Then make install also works just fine (or it should).
> > What you propose (+ the configure line that is already there) should probably be used by distributions for making a package which is going to install in system paths. Manual compiles should try to stay away from that.
> >
> > Or that's how i'm used to it.
Well, I have uploaded an updated diff that follows what was pointed in the previous comment. If it's better to leave it the way it is at present, then I'll change this RR as discarded.
Now, I'm getting a little confused o_O
- R.Harish
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/119092/#review61514
-----------------------------------------------------------
On July 2, 2014, 10:53 p.m., R.Harish Navnit wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.org/r/119092/
> -----------------------------------------------------------
>
> (Updated July 2, 2014, 10:53 p.m.)
>
>
> Review request for Plasma, Shantanu Tushar and Sinny Kumari.
>
>
> Repository: plasma-mediacenter
>
>
> Description
> -------
>
> Giving the command "make install" without sudo doesn't work. Has this gone un-noticed or is this how it is intended in the README ?
>
>
> Diffs
> -----
>
> README 6f46cdf
>
> Diff: https://git.reviewboard.kde.org/r/119092/diff/
>
>
> Testing
> -------
>
> Ran "sudo make install" and build succeeds.
>
>
> Thanks,
>
> R.Harish Navnit
>
>
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/plasma-devel/attachments/20140702/3a483f62/attachment.html>
More information about the Plasma-devel
mailing list