Review Request 118974: UserAccount KCM: Change the name using the AccountManager
Vishesh Handa
me at vhanda.in
Tue Jul 1 10:15:00 UTC 2014
> On July 1, 2014, 10:08 a.m., Commit Hook wrote:
> > This review has been submitted with commit 77275f50241eb2f4e38051152074c379fa96fe84 by Vishesh Handa to branch frameworks.
Alex gave me a ship it via IM.
- Vishesh
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/118974/#review61357
-----------------------------------------------------------
On July 1, 2014, 10:08 a.m., Vishesh Handa wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.org/r/118974/
> -----------------------------------------------------------
>
> (Updated July 1, 2014, 10:08 a.m.)
>
>
> Review request for Plasma and Àlex Fiestas.
>
>
> Repository: kde-baseapps
>
>
> Description
> -------
>
> UserAccount KCM: Change the name using the AccountManager
>
> Instead of calling chfn, parsing its output (which depends on the
> version of chfn which is present) and also additionally requires the
> password.
>
> This is also much more secure since we aren't storing the password in
> memory.
>
>
> Diffs
> -----
>
> kdepasswd/kcm/CMakeLists.txt ddb2ed6
> kdepasswd/kcm/chfnprocess.h 9f962e2
> kdepasswd/kcm/chfnprocess.cpp fca8e25
> kdepasswd/kcm/main.cpp 25f9001
>
> Diff: https://git.reviewboard.kde.org/r/118974/diff/
>
>
> Testing
> -------
>
>
> Thanks,
>
> Vishesh Handa
>
>
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/plasma-devel/attachments/20140701/64934903/attachment.html>
More information about the Plasma-devel
mailing list