Review Request 118974: UserAccount KCM: Change the name using the AccountManager
Sebastian Kügler
sebas at kde.org
Tue Jul 1 09:08:12 UTC 2014
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/118974/#review61084
-----------------------------------------------------------
I'm not familiar with AccountsService, would appreciate someone who is to have a look.
In principle, I'm OK with this patch.
kdepasswd/kcm/main.cpp
<https://git.reviewboard.kde.org/r/118974/#comment42539>
Perhaps convert to using KMessageWidget, while at it?
- Sebastian Kügler
On June 30, 2014, 1:16 p.m., Vishesh Handa wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.org/r/118974/
> -----------------------------------------------------------
>
> (Updated June 30, 2014, 1:16 p.m.)
>
>
> Review request for Plasma and Àlex Fiestas.
>
>
> Repository: kde-baseapps
>
>
> Description
> -------
>
> UserAccount KCM: Change the name using the AccountManager
>
> Instead of calling chfn, parsing its output (which depends on the
> version of chfn which is present) and also additionally requires the
> password.
>
> This is also much more secure since we aren't storing the password in
> memory.
>
>
> Diffs
> -----
>
> kdepasswd/kcm/CMakeLists.txt ddb2ed6
> kdepasswd/kcm/chfnprocess.h 9f962e2
> kdepasswd/kcm/chfnprocess.cpp fca8e25
> kdepasswd/kcm/main.cpp 25f9001
>
> Diff: https://git.reviewboard.kde.org/r/118974/diff/
>
>
> Testing
> -------
>
>
> Thanks,
>
> Vishesh Handa
>
>
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/plasma-devel/attachments/20140701/cc18ebce/attachment.html>
More information about the Plasma-devel
mailing list