Review Request 115397: fix theme cache cleanup and discarding (v2)

[David Edmundson]

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/115397/#review48634
-----------------------------------------------------------

Ship it!


Looks sensible to me, thanks.

- David Edmundson


On Jan. 30, 2014, 12:24 p.m., Aaron J. Seigo wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.org/r/115397/
> -----------------------------------------------------------
> 
> (Updated Jan. 30, 2014, 12:24 p.m.)
> 
> 
> Review request for Plasma, Martin Klapetek and Harald Sitter.
> 
> 
> Repository: kdelibs
> 
> 
> Description
> -------
> 
> A variation of https://git.reviewboard.kde.org/r/115326 which also cleans up when the metadata.desktop file in the theme changes at runtime.
> 
> This resulted in moving the creation of the svg cache file into useCache(), which makes more sense anyways. Even if discardCache was always called before methods checked for d->svgElementsCache, that is obviously not only non-intuitive but hard to track in the code (changes are scheduled via a timer...) making that more brittle than necessary. Upon review of the code, there is no reason to expect there to be an svg elements cache if caching is turned off (the svg files need to be opened in that case anyways, so nothing is really being saved). This simplifies discardCaches and creates consistency between how the two cache files (image and svg elements) are used in the rest of the code base.
> 
> Fixes pulled in from Harald's patch include checking the time of the file before creating the image cache object to preserve correct mtime and versioning the image cache file name appropriately. 
> 
> Note that this means that plasma themes can now be updated while in use (e.g. plasma-desktop is running) and the visuals will adapt accordingly.
> 
> 
> Diffs
> -----
> 
>   plasma/theme.cpp cb44878 
> 
> Diff: https://git.reviewboard.kde.org/r/115397/diff/
> 
> 
> Testing
> -------
> 
> changed desktop theme version in meatadata.desktop between runs of plasma-desktop: cache files changed to correct versions
> 
> changed config file *during* plasma-desktop running: caches files changed to correct versions
> 
> no change between runs: cache files retained
> 
> 
> Thanks,
> 
> Aaron J. Seigo
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/plasma-devel/attachments/20140130/5f0c4ca2/attachment.html>