Review Request 112959: Add color picker in plasmaextracomponents

[David Edmundson]

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/112959/#review48618
-----------------------------------------------------------



src/declarativeimports/plasmaextracomponents/qml/ColorPicker.qml
<https://git.reviewboard.kde.org/r/112959/#comment34340>

    That's not your name.



src/declarativeimports/plasmaextracomponents/qml/ColorPicker.qml
<https://git.reviewboard.kde.org/r/112959/#comment34341>

    This isn't used.



src/declarativeimports/plasmaextracomponents/qml/ColorPicker.qml
<https://git.reviewboard.kde.org/r/112959/#comment34342>

    Don't commit commented out code.


I'm not sure how needed this is.

WidgetColorDialog got merged into QtQuickControls (targeting Qt5.3).

- David Edmundson


On Sept. 26, 2013, 4:36 p.m., Bhushan Shah wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.org/r/112959/
> -----------------------------------------------------------
> 
> (Updated Sept. 26, 2013, 4:36 p.m.)
> 
> 
> Review request for Plasma and Marco Martin.
> 
> 
> Repository: plasma-framework
> 
> 
> Description
> -------
> 
> Add color picker in PlasmaExtras
> 
> 
> Diffs
> -----
> 
>   src/declarativeimports/plasmaextracomponents/qml/ColorPicker.qml PRE-CREATION 
>   src/declarativeimports/plasmaextracomponents/qml/qmldir c59e62f 
> 
> Diff: https://git.reviewboard.kde.org/r/112959/diff/
> 
> 
> Testing
> -------
> 
> 
> Thanks,
> 
> Bhushan Shah
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/plasma-devel/attachments/20140130/59389f06/attachment-0001.html>