Review Request 115393: Add property to allow Dialog Popups to align to visualParent item's window

[David Edmundson]

> On Jan. 30, 2014, 9:38 a.m., Marco Martin wrote:
> > I don't think it's the right way..
> > thinking about it, that's true for panels as well, (even tough is already forced by extended structs, but is not a given since the other panel modes still have to come back)
> > 
> > what it suggests me is that this should depend from the visualparent window type, but not from an ad-hoc api for sure
> 
> David Edmundson wrote:
>     So to confirm:
>     I keep the logic, but I drop having an explicit property.
>     Instead I determine which mode to do based on the type of item->window() ?
>
> 
> Marco Martin wrote:
>     yeah, i think docks..
>     (apart from the fact that it accepts focus, the widget explorer in its current rendition is pretty much a dock window, so better if it has the hint.. it would stop to be sometimes randomly repositioned as well)

OK. That seems better to me. 

WidgetExplorer is already a dock (according to xwininfo anyway) so unfortunately that won't fix the random positioning.


- David


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/115393/#review48588
-----------------------------------------------------------


On Jan. 29, 2014, 10:51 p.m., David Edmundson wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.org/r/115393/
> -----------------------------------------------------------
> 
> (Updated Jan. 29, 2014, 10:51 p.m.)
> 
> 
> Review request for Plasma.
> 
> 
> Repository: plasma-framework
> 
> 
> Description
> -------
> 
> 
> For the WidgetExplorer we want to show the tooltips to the right of the
> scrollbar in the view, not to the right of the delegate the tooltip is
> for.
> This patch adds a boolean flag which shifts it to the nearest point to
> the visualParent which is outside the visualParent's window - in this
> case outside the scrollbar.
> 
> I have also introduced a manual test for Dialog Positioning, and
> includied some fixes in the original logic.
> 
> 
> Diffs
> -----
> 
>   src/declarativeimports/core/dialog.cpp 0248596 
>   src/declarativeimports/core/tests/manual/dialog_positioning.qml PRE-CREATION 
>   src/declarativeimports/core/dialog.h dc2b688 
> 
> Diff: https://git.reviewboard.kde.org/r/115393/diff/
> 
> 
> Testing
> -------
> 
> 
> Thanks,
> 
> David Edmundson
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/plasma-devel/attachments/20140130/6605afee/attachment.html>