Status on using KStatusNotifierItem for QSystemTrayIcon

[Kevin Krammer]

On Wednesday, 2014-01-29, 14:52:09, Martin Gräßlin wrote:

> * Current patches *
> 1. Patch to extend Qt by all I need to get the menu properly passed to our
> implementation: https://codereview.qt-project.org/76864
> 2. Patch to not build the X11 implementation and force to QPA:
> 
> diff --git a/src/widgets/util/util.pri b/src/widgets/util/util.pri
> index b4bbc5f..aab9719 100644
> --- a/src/widgets/util/util.pri
> +++ b/src/widgets/util/util.pri
> @@ -29,8 +29,6 @@ SOURCES += \
> 
>  win32:!wince*:!winrt {
>      SOURCES += util/qsystemtrayicon_win.cpp
> -} else:contains(QT_CONFIG, xcb) {
> -    SOURCES += util/qsystemtrayicon_x11.cpp
>  } else {
>      SOURCES += util/qsystemtrayicon_qpa.cpp
>  }
> 
> This obviously is not a solution. If I get positive reviews on item 1 I will
> start to move the X11 implementation to the xcb plugin.

I think that should be done independently, i.e. that is a good idea in any 
case, independent of whether the review for (1) finds support.
Moving the X11 systray icon implementation into the XCB plugin reduces 
platform specific code in qtbase/src/widgets and places it where it belongs 
(the QPA).

Given the diff snippet X11 is the only remaining platform beside Windows where 
this has not happened yet.

> Any support on the Qt code review will be appreciated :-)

Looking at it right away.

Cheers,
Kevin
-- 
Kevin Krammer, KDE developer, xdg-utils developer
KDE user support, developer mentoring
-------------- next part --------------
A non-text attachment was scrubbed...
Name: signature.asc
Type: application/pgp-signature
Size: 190 bytes
Desc: This is a digitally signed message part.
URL: <http://mail.kde.org/pipermail/plasma-devel/attachments/20140129/14d73538/attachment.sig>