Review Request 115326: fix theme cache cleanup and discarding

[Martin Klapetek]

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/115326/#review48389
-----------------------------------------------------------

Ship it!


Seems good to me


plasma/theme.cpp
<https://git.reviewboard.kde.org/r/115326/#comment34217>

    Make both QLatin1String (or both plain strings)



plasma/theme.cpp
<https://git.reviewboard.kde.org/r/115326/#comment34218>

    Nuoooo



plasma/theme.cpp
<https://git.reviewboard.kde.org/r/115326/#comment34219>

    Seems like these two could be squashed into one but...meh, up to you



plasma/theme.cpp
<https://git.reviewboard.kde.org/r/115326/#comment34220>

    One thing I don't understand (not related to your changes though) - why does this return cacheTheme which never ever changes inside this method? And it also never returns anywhere else, so why is it even returning a boolean value when its value is already known before this method? :O


- Martin Klapetek


On Jan. 27, 2014, 12:30 p.m., Harald Sitter wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.org/r/115326/
> -----------------------------------------------------------
> 
> (Updated Jan. 27, 2014, 12:30 p.m.)
> 
> 
> Review request for Plasma, Aaron J. Seigo and Martin Klapetek.
> 
> 
> Repository: kdelibs
> 
> 
> Description
> -------
> 
> - introduce svgelements cache handling in useCache()
> - to decide whether or not to discard a cache type now the mtimes of metadata.desktop and the respective cache file are compared (previously this was an invalid file compared to cache change time)
> - cache cleanup now happens entirely before creation of the KImageCache instance to prevent any sort of problem there
> 
> - add fixme comment about broken version-based cache handling. for one the version specific file name is not actually used for the KImageCache and for another the entire shebang is missing from svgelements all together. this has the very unfortunate side effect that the *active* cache files are deleted ever so often, it may be worth removing the code portions until someone finds time/interest to actually implement this in a working fashion.
> 
> 
> Diffs
> -----
> 
>   plasma/theme.cpp cb44878 
> 
> Diff: https://git.reviewboard.kde.org/r/115326/diff/
> 
> 
> Testing
> -------
> 
> upgraded from 4.8 straight to 4.12 -> theme caches correctly discarded
> 
> 
> Thanks,
> 
> Harald Sitter
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/plasma-devel/attachments/20140127/af61ae3f/attachment-0001.html>