Review Request 115324: Remove extra include from taglib to allow older versions of taglib to be used.

Matthew John Dawson matthew at mjdsystems.ca
Mon Jan 27 04:27:03 UTC 2014


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/115324/
-----------------------------------------------------------

(Updated Jan. 26, 2014, 11:27 p.m.)


Review request for Plasma, Shantanu Tushar and Sinny Kumari.


Changes
-------

Fix patch file, somehow the header had managed to get added back.


Repository: plasma-mediacenter


Description
-------

Plasma Mediacenter includes an extra file from taglib that only exists in taglib 1.8.  However, this include is not actually used, and not using it allows Plasma Mediacenter to compile with taglib 1.7.  This change is required for Plasma Active as it is using taglib 1.7 for now.


Diffs (updated)
-----

  libs/mediacenter/mediainfoservice.cpp fb52b03 

Diff: https://git.reviewboard.kde.org/r/115324/diff/


Testing
-------

Compiling with both gcc and clang produce no warnings or errors.  gcc generates the exact same assembly for both versions.


Thanks,

Matthew John Dawson

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/plasma-devel/attachments/20140127/2b65fa6a/attachment.html>


More information about the Plasma-devel mailing list