Review Request 115301: Add OSD notifications to plasma-shell

[Martin Klapetek]

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/115301/
-----------------------------------------------------------

(Updated Jan. 25, 2014, 6:31 p.m.)


Review request for Plasma.


Changes
-------

* moved to corona
* renamed from OSD to Osd
* changed the way it's shown & hidden (less risky)
* cleaned ALL the issues o/


Repository: plasma-framework


Description
-------

As we decided to make the OSD available only for certain things, the API is intentionally limited to very particular set of things. The list is not complete yet I believe, but I'd like to get comments on the general design and state.

Also as it's not a public service, I left it under org.kde.plasma_shell on D-Bus. Makes sense? Does not? Should it be standalone at eg. org.kde.osd?

Note: This still needs patches in kwin.


Diffs (updated)
-----

  src/shell/shellcorona.cpp f565d79 
  src/shell/osd.cpp PRE-CREATION 
  src/shell/osd.h PRE-CREATION 
  src/shell/CMakeLists.txt 5c4b360 

Diff: https://git.reviewboard.kde.org/r/115301/diff/


Testing
-------

Can be invoked using qdbus from command line. Works rather well.


Thanks,

Martin Klapetek

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/plasma-devel/attachments/20140125/5bba5cd4/attachment.html>