Review Request 115284: Provide KFormat wrapper as QML plugin
Sebastian Kügler
sebas at kde.org
Fri Jan 24 11:24:57 UTC 2014
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/115284/#review48190
-----------------------------------------------------------
Ship it!
Ship It!
- Sebastian Kügler
On Jan. 24, 2014, 11:20 a.m., Bhushan Shah wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.org/r/115284/
> -----------------------------------------------------------
>
> (Updated Jan. 24, 2014, 11:20 a.m.)
>
>
> Review request for Plasma.
>
>
> Repository: plasma-framework
>
>
> Description
> -------
>
> In Plasma1 KLocale wrapper was used to format different things like duration, it was removed and also KLocale was split up so here is KFormat wrapper to use this methods.
>
> I found no better place then qtextracomponents, should be different import?
>
>
> Diffs
> -----
>
> src/declarativeimports/core/CMakeLists.txt 71f2cb3
> src/declarativeimports/core/corebindingsplugin.cpp acc7cb7
> src/declarativeimports/core/formats.h PRE-CREATION
> src/declarativeimports/core/formats.cpp PRE-CREATION
>
> Diff: https://git.reviewboard.kde.org/r/115284/diff/
>
>
> Testing
> -------
>
> Tested formatDuration in battery monitor.
>
>
> Thanks,
>
> Bhushan Shah
>
>
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/plasma-devel/attachments/20140124/ec99bfed/attachment.html>
More information about the Plasma-devel
mailing list