Review Request 115284: Provide KFormat wrapper as QML plugin
Bhushan Shah
bhush94 at gmail.com
Fri Jan 24 07:49:26 UTC 2014
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/115284/
-----------------------------------------------------------
(Updated Jan. 24, 2014, 1:19 p.m.)
Review request for Plasma.
Repository: plasma-framework
Description (updated)
-------
In Plasma1 KLocale wrapper was used to format different things like duration, it was removed and also KLocale was split up so here is KFormat wrapper to use this methods.
I found no better place then qtextracomponents, should be different import?
Diffs
-----
src/declarativeimports/qtextracomponents/CMakeLists.txt 0ae9e17
src/declarativeimports/qtextracomponents/format.h PRE-CREATION
src/declarativeimports/qtextracomponents/format.cpp PRE-CREATION
src/declarativeimports/qtextracomponents/qtextracomponentsplugin.cpp d3f8149
Diff: https://git.reviewboard.kde.org/r/115284/diff/
Testing
-------
Tested formatDuration in battery monitor.
Thanks,
Bhushan Shah
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/plasma-devel/attachments/20140124/aa3c2a3e/attachment.html>
More information about the Plasma-devel
mailing list