Review Request 115256: Provide look&feel package by ShellCorona

Sebastian Kügler sebas at kde.org
Thu Jan 23 14:48:27 UTC 2014


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/115256/#review48125
-----------------------------------------------------------



src/shell/shellcorona.h
<https://git.reviewboard.kde.org/r/115256/#comment34045>

    Should be lookAndFeelPackage()
    
    lookNFeel is inconsistent with the naming elsewhere.
    
    It's not Rock'n Roll :P


- Sebastian Kügler


On Jan. 23, 2014, 12:38 p.m., Martin Klapetek wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.org/r/115256/
> -----------------------------------------------------------
> 
> (Updated Jan. 23, 2014, 12:38 p.m.)
> 
> 
> Review request for Plasma.
> 
> 
> Repository: plasma-framework
> 
> 
> Description
> -------
> 
> Makes lookNFeel package universally available from ShellCorona.
> 
> 
> Diffs
> -----
> 
>   src/shell/shellcorona.h becc625 
>   src/shell/shellcorona.cpp 35e91cd 
> 
> Diff: https://git.reviewboard.kde.org/r/115256/diff/
> 
> 
> Testing
> -------
> 
> 
> Thanks,
> 
> Martin Klapetek
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/plasma-devel/attachments/20140123/ecfcb56d/attachment.html>


More information about the Plasma-devel mailing list