Review Request 115258: Do not overwrite the window type by calling setFlags

[Commit Hook]

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/115258/#review48114
-----------------------------------------------------------


This review has been submitted with commit 188e4219567de12527eea51148372a608a91f6a3 by Martin Gräßlin to branch master.

- Commit Hook


On Jan. 23, 2014, 12:55 p.m., Martin Gräßlin wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.org/r/115258/
> -----------------------------------------------------------
> 
> (Updated Jan. 23, 2014, 12:55 p.m.)
> 
> 
> Review request for Plasma and Martin Klapetek.
> 
> 
> Repository: plasma-framework
> 
> 
> Description
> -------
> 
> Do not overwrite the window type by calling setFlags
> 
> QWindow::setFlags is manipulating the same X property as
> KWindowSystem::setType. Thus our setType never succeeded as the
> setFlags overwrote the window type again. In the same way we
> have to call setFlags when reverting to the default Normal type.
> 
> 
> Diffs
> -----
> 
>   src/declarativeimports/core/dialog.cpp cb5ab505744f037333eee738d8a33a946ecf255b 
> 
> Diff: https://git.reviewboard.kde.org/r/115258/diff/
> 
> 
> Testing
> -------
> 
> Tested properties of Kickoff dialog (default ones) and Martin's new OSD (notification)
> 
> 
> Thanks,
> 
> Martin Gräßlin
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/plasma-devel/attachments/20140123/18ba15a2/attachment.html>