Review Request 115219: Remove KTimeZone usage in time dataengine and port it to QTimeZone

[Martin Klapetek]

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/115219/#review47994
-----------------------------------------------------------



plasma/generic/dataengines/time/timeengine.cpp
<https://git.reviewboard.kde.org/r/115219/#comment34003>

    I think this can be nicer by doing
    
    Q_FOREACH(const QByteArray &tz, QTimeZone::availableTimeZoneIds()) {
        sources << QString(tz.constData());
    }


- Martin Klapetek


On Jan. 22, 2014, 12:26 p.m., Bhushan Shah wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.org/r/115219/
> -----------------------------------------------------------
> 
> (Updated Jan. 22, 2014, 12:26 p.m.)
> 
> 
> Review request for Plasma and Martin Klapetek.
> 
> 
> Repository: kde-workspace
> 
> 
> Description
> -------
> 
> $summary + KDE4Support-- + cleanup
> 
> 
> Diffs
> -----
> 
>   plasma/generic/dataengines/time/CMakeLists.txt e4aebab 
>   plasma/generic/dataengines/time/timeengine.cpp 5155527 
> 
> Diff: https://git.reviewboard.kde.org/r/115219/diff/
> 
> 
> Testing
> -------
> 
> compiles, links and tested in plasmaengineexplorer
> 
> 
> Thanks,
> 
> Bhushan Shah
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/plasma-devel/attachments/20140122/d3f67f9d/attachment.html>