Review Request 115162: Launch single instance of plasma-mediacenter

[Shantanu Tushar]

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/115162/#review47915
-----------------------------------------------------------


I couldn't try it right now but I have this doubt. If there is already a PMC instance running and open a file from Dolphin, does the file indeed start playing?


shells/newshell/application.cpp
<https://git.reviewboard.kde.org/r/115162/#comment33931>

    use initialization lists syntax-
    
    Application::Application()
        : KUniqueApplication()
        , m_mainWindow(0)



shells/newshell/application.cpp
<https://git.reviewboard.kde.org/r/115162/#comment33932>

    Pass this as parent so that it can be deleted when the application exits
    
    m_mainWindow = new MainWindow(this);


- Shantanu Tushar


On Jan. 21, 2014, 6:44 a.m., Sujith Haridasan wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.org/r/115162/
> -----------------------------------------------------------
> 
> (Updated Jan. 21, 2014, 6:44 a.m.)
> 
> 
> Review request for Plasma, Shantanu Tushar and Sinny Kumari.
> 
> 
> Repository: plasma-mediacenter
> 
> 
> Description
> -------
> 
> Launching single instance of plasma-mediacenter. Using KUniqueApplication only single instance of plasma-mediacenter is launched.
> 
> 
> Diffs
> -----
> 
>   shells/newshell/CMakeLists.txt 60949df 
>   shells/newshell/application.h PRE-CREATION 
>   shells/newshell/application.cpp PRE-CREATION 
>   shells/newshell/main.cpp 9fd5df3 
>   shells/newshell/plasma-mediacenter.desktop c3c5781 
> 
> Diff: https://git.reviewboard.kde.org/r/115162/diff/
> 
> 
> Testing
> -------
> 
> Tests done using konsole:
> a) Open a tab and launch pmc.
> b) Open another tab and try to launch another instance of pmc.
> c) After executing (b) pmc wont launch because already another instance of pmc from (a) is already running.
> 
> Tests done using Dolphin:
> a) Go to the music folder and right click on the file to be played. Click open with and launch pmc.
> b) Try to open another file using same step as (a)
> c) After executing (b) wait for few seconds and you can see that only single instance of (a) will be running.
> 
> 
> Thanks,
> 
> Sujith Haridasan
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/plasma-devel/attachments/20140121/9aee6ee0/attachment.html>