Review Request 115139: Add outputOnly property to PlasmaCore.Dialog

[Sebastian Kügler]

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/115139/#review47767
-----------------------------------------------------------

Ship it!


looks good. :)

- Sebastian Kügler


On Jan. 20, 2014, 9:20 a.m., Martin Gräßlin wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.org/r/115139/
> -----------------------------------------------------------
> 
> (Updated Jan. 20, 2014, 9:20 a.m.)
> 
> 
> Review request for Plasma and Martin Klapetek.
> 
> 
> Repository: plasma-framework
> 
> 
> Description
> -------
> 
> Add outputOnly property to PlasmaCore.Dialog
> 
> The outputOnly property allows to specify that the dialog should not
> accept any input. Thus it's an output only window which supports click
> through. This is obviously platform specific and so far it is only
> implemented for the X11 platform using the shape extension.
> 
> The input shape needs to be set once the window is visible and thus
> the functionality is bound to the visible changed signal. The code
> ensures that the required shape extension version is present and only
> fetches it once.
> 
> 
> Diffs
> -----
> 
>   CMakeLists.txt ef64bdc7c666bf00205f91ff8bce4fee1a6f47c6 
>   src/declarativeimports/core/CMakeLists.txt 71f2cb351fe8bf45af563dad39a76fe75da4a0f6 
>   src/declarativeimports/core/dialog.h f5d00afc66e52d6049d40f5c76a9ba25135d20f7 
>   src/declarativeimports/core/dialog.cpp 2c15f30c10b92870c727e05605bc16aec5836d40 
> 
> Diff: https://git.reviewboard.kde.org/r/115139/diff/
> 
> 
> Testing
> -------
> 
> Tested using KWin's desktop change OSD which used to be click-through before the switch to QML.
> 
> 
> Thanks,
> 
> Martin Gräßlin
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/plasma-devel/attachments/20140120/fd290f07/attachment.html>