Review Request 115046: Reduce timeout of startupfeedback to a sensible default

[Martin Klapetek]

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/115046/#review47473
-----------------------------------------------------------

Ship it!


Looks good; preferably give it a day for possible objections (and then nail them ;)


libs/taskmanager/taskmanager.cpp
<https://git.reviewboard.kde.org/r/115046/#comment33753>

    Can we make the var in "
    kcontrol/launch/kcmlaunch.cpp" named like this one? I'd prefer all three being named the same, though I can see why the capslock variant in startupfeedback.cpp


- Martin Klapetek


On Jan. 15, 2014, 9:04 p.m., Martin Gräßlin wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.org/r/115046/
> -----------------------------------------------------------
> 
> (Updated Jan. 15, 2014, 9:04 p.m.)
> 
> 
> Review request for Plasma.
> 
> 
> Repository: kde-workspace
> 
> 
> Description
> -------
> 
> It's 2014 and we don't have to wait half a minute for an application to start.
> In fact we mostly get false positives due to applications not handling correctly
> startup notifications for already running instances (e.g. click on link in email).
> 
> So let's reduce to a default which doesn't look like a broken setup.
> 
> 
> Diffs
> -----
> 
>   kcontrol/launch/kcmlaunch.cpp fc9543e 
>   kwin/effects/startupfeedback/startupfeedback.cpp d700138 
>   libs/taskmanager/taskmanager.cpp 2b3bdc5 
> 
> Diff: https://git.reviewboard.kde.org/r/115046/diff/
> 
> 
> Testing
> -------
> 
> 
> Thanks,
> 
> Martin Gräßlin
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/plasma-devel/attachments/20140115/c0033b24/attachment.html>