Review Request 115027: Port the share DataEngine from Kross to KJsEmbed

Aleix Pol Gonzalez aleixpol at kde.org
Wed Jan 15 13:47:06 UTC 2014


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/115027/
-----------------------------------------------------------

Review request for Plasma and Vishesh Handa.


Repository: kde-workspace


Description
-------

Kross's KJS backend was dropped because it was unstable and the original author suggested us to do so.

I was trying to get this data engine to work, so I decided to port it to use KJsEmbed directly. Only JS was being used so far so I think it's a safe change. 


Diffs
-----

  CMakeLists.txt 592198b 
  plasma/generic/dataengines/share/CMakeLists.txt 2dcfd02 
  plasma/generic/dataengines/share/shareprovider.h d17ddd9 
  plasma/generic/dataengines/share/shareprovider.cpp fc528f8 
  plasma/generic/dataengines/share/shareservice.h 9983292 
  plasma/generic/dataengines/share/shareservice.cpp 272a467 

Diff: https://git.reviewboard.kde.org/r/115027/diff/


Testing
-------

I uploaded a paste with the half-ported plasmoid.


Thanks,

Aleix Pol Gonzalez

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/plasma-devel/attachments/20140115/803e7dfb/attachment-0001.html>


More information about the Plasma-devel mailing list