Review Request 114932: Use QExplicitlySharedDataPointer as the replacement of KSharedPtr
Aurélien Gâteau
agateau at kde.org
Tue Jan 14 13:33:27 UTC 2014
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/114932/#review47363
-----------------------------------------------------------
Ship it!
OK, go for it then.
- Aurélien Gâteau
On Jan. 9, 2014, 8:14 p.m., Alexander Richardson wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.org/r/114932/
> -----------------------------------------------------------
>
> (Updated Jan. 9, 2014, 8:14 p.m.)
>
>
> Review request for Plasma and Aurélien Gâteau.
>
>
> Repository: plasma-framework
>
>
> Description
> -------
>
> This should be slightly more efficient than the solution from e7e2eedd
> which uses QWeakPointer and QSharedPointer
>
>
> Diffs
> -----
>
> src/plasma/private/svg_p.h 16ed29638b6b253d1fefc220341b91f20c2d76d5
> src/plasma/svg.cpp ae97783308574c9478b6f194b8460a457a2a187e
>
> Diff: https://git.reviewboard.kde.org/r/114932/diff/
>
>
> Testing
> -------
>
> compiles
>
>
> Thanks,
>
> Alexander Richardson
>
>
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/plasma-devel/attachments/20140114/6677221e/attachment.html>
More information about the Plasma-devel
mailing list