Review Request 114925: Add a new component ModelMenu

Sebastian Kügler sebas at kde.org
Thu Jan 9 16:22:33 UTC 2014


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/114925/#review47112
-----------------------------------------------------------

Ship it!


Looking nice and clean.


src/declarativeimports/plasmacomponents/qml/ModelContextMenu.qml
<https://git.reviewboard.kde.org/r/114925/#comment33574>

    typeof(modelData) (no space, also on other lines)


- Sebastian Kügler


On Jan. 9, 2014, 4:14 p.m., David Edmundson wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.org/r/114925/
> -----------------------------------------------------------
> 
> (Updated Jan. 9, 2014, 4:14 p.m.)
> 
> 
> Review request for Plasma.
> 
> 
> Repository: plasma-framework
> 
> 
> Description
> -------
> 
> Add a new component ModelMenu
> 
> This is a wrapper round ContextMenu that allows one to populate
> the menu items from a model
> 
> 
> Diffs
> -----
> 
>   src/declarativeimports/plasmacomponents/qml/ModelContextMenu.qml PRE-CREATION 
>   src/declarativeimports/plasmacomponents/qml/qmldir ee8edee 
> 
> Diff: https://git.reviewboard.kde.org/r/114925/diff/
> 
> 
> Testing
> -------
> 
> 
> Thanks,
> 
> David Edmundson
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/plasma-devel/attachments/20140109/a7ff3952/attachment.html>


More information about the Plasma-devel mailing list