Review Request 114925: Add a new component ModelMenu

[David Edmundson]

> On Jan. 9, 2014, 2:15 p.m., Sebastian Kügler wrote:
> > Have you thought about folding this into ContextMenu, so we don't need an extra component?

I thought about it. Then gave up :)

Problem comes from having an interface which now has to support:
 - a QList<QActions*>
 - a QAbstractItemModel
 - _and_ child MenuItems

Though in the process of writing this I now have a plan in my head that would work.

Disadvantage of folding it into ContextMenu is it will make it harder to switch to QtQuickControls.Menu in the future.


- David


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/114925/#review47109
-----------------------------------------------------------


On Jan. 9, 2014, 1:10 p.m., David Edmundson wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.org/r/114925/
> -----------------------------------------------------------
> 
> (Updated Jan. 9, 2014, 1:10 p.m.)
> 
> 
> Review request for Plasma.
> 
> 
> Repository: plasma-framework
> 
> 
> Description
> -------
> 
> Add a new component ModelMenu
> 
> This is a wrapper round ContextMenu that allows one to populate
> the menu items from a model
> 
> 
> Diffs
> -----
> 
>   src/declarativeimports/plasmacomponents/qml/ModelMenu.qml PRE-CREATION 
>   src/declarativeimports/plasmacomponents/qml/qmldir ee8edee 
> 
> Diff: https://git.reviewboard.kde.org/r/114925/diff/
> 
> 
> Testing
> -------
> 
> 
> Thanks,
> 
> David Edmundson
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/plasma-devel/attachments/20140109/2a7012a0/attachment.html>