Review Request 114923: Super simplify AppletDelegate

Marco Martin notmart at gmail.com
Thu Jan 9 11:21:43 UTC 2014


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/114923/#review47099
-----------------------------------------------------------

Ship it!



plasma/qmlpackages/desktop/contents/explorer/AppletDelegate.qml
<https://git.reviewboard.kde.org/r/114923/#comment33571>

    whitespace


- Marco Martin


On Jan. 9, 2014, 11:19 a.m., David Edmundson wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.org/r/114923/
> -----------------------------------------------------------
> 
> (Updated Jan. 9, 2014, 11:19 a.m.)
> 
> 
> Review request for Plasma.
> 
> 
> Repository: kde-workspace
> 
> 
> Description
> -------
> 
> Super simplify AppletDelegate
> 
> 
> I don't understand what the original timer was trying to do. It seems like the original author thought wrap and elide were mutually exclusive. Everything behaves fine (if not better) with this. If you resize such that a single long word doesn't fit it is elided. As far as I can tell all functionality is kept the same.
> 
> 
> Diffs
> -----
> 
>   plasma/qmlpackages/desktop/contents/explorer/AppletDelegate.qml 9db63c5 
> 
> Diff: https://git.reviewboard.kde.org/r/114923/diff/
> 
> 
> Testing
> -------
> 
> 
> Thanks,
> 
> David Edmundson
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/plasma-devel/attachments/20140109/a93dc6e6/attachment.html>


More information about the Plasma-devel mailing list