Review Request 114912: KSharedPtr => QWeakPointer and QSharedPointer

[Aurélien Gâteau]

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/114912/
-----------------------------------------------------------

(Updated Jan. 9, 2014, 9:15 a.m.)


Status
------

This change has been marked as submitted.


Review request for Plasma.


Repository: plasma-framework


Description
-------

Replace use of KSharedPtr with a QWeakPointer and QSharedPointer in Plasma::Svg.

This removes the last dependency from plasma-framework on kde4support.

This change is a bit more involved than other kde4support removals because QSharedPointer does not provide a count() method. I therefore reworked the code to store the SharedSvgRenderer as a QWeakPointer in s_renderers, making it possible to detect when the last one goes away by creating a QWeakPointer guard in SvgPrivate::eraseRenderer().


Diffs
-----

  CMakeLists.txt 8b60011 
  src/plasma/CMakeLists.txt aced599 
  src/plasma/private/svg_p.h 5fdebf3 
  src/plasma/svg.cpp 6542b34 

Diff: https://git.reviewboard.kde.org/r/114912/diff/


Testing
-------

Ran a plasma-shell session, did not notice any crash.


Thanks,

Aurélien Gâteau

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/plasma-devel/attachments/20140109/72426235/attachment.html>