Review Request 114914: Move WidgetExplorer to be a private QML plugin

David Edmundson david at davidedmundson.co.uk
Wed Jan 8 19:45:24 UTC 2014


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/114914/
-----------------------------------------------------------

(Updated Jan. 8, 2014, 7:45 p.m.)


Status
------

This change has been marked as submitted.


Review request for Plasma.


Repository: plasma-framework


Description
-------

Move WidgetExplorer to be a private QML plugin

Instead of registering WidgetExplorer inside the shell, create a new qml
plugin in the org.kde.plasma.private namespace.

This is useful for running widgetexplorer in qmlscene.

This makes testing, debugging and profiling considerably easier.


Diffs
-----

  src/shell/CMakeLists.txt 17713a1 
  src/shell/shellcorona.cpp 2870402 
  src/shell/widgetexplorer/CMakeLists.txt PRE-CREATION 
  src/shell/widgetexplorer/qmldir PRE-CREATION 
  src/shell/widgetexplorer/widgetexplorerplugin.h PRE-CREATION 
  src/shell/widgetexplorer/widgetexplorerplugin.cpp PRE-CREATION 

Diff: https://git.reviewboard.kde.org/r/114914/diff/


Testing
-------

Ran WidgetExplorer.qml in qmlscene. Also ran plasma-shell and confirmed that behaves as before.


Thanks,

David Edmundson

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/plasma-devel/attachments/20140108/1c3a9528/attachment.html>


More information about the Plasma-devel mailing list