Review Request 114914: Move WidgetExplorer to be a private QML plugin

[Marco Martin]

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/114914/#review47079
-----------------------------------------------------------

Ship it!


this was rotting away in my todo list since a while, yay :)

- Marco Martin


On Jan. 8, 2014, 7:13 p.m., David Edmundson wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.org/r/114914/
> -----------------------------------------------------------
> 
> (Updated Jan. 8, 2014, 7:13 p.m.)
> 
> 
> Review request for Plasma.
> 
> 
> Repository: plasma-framework
> 
> 
> Description
> -------
> 
> Move WidgetExplorer to be a private QML plugin
> 
> Instead of registering WidgetExplorer inside the shell, create a new qml
> plugin in the org.kde.plasma.private namespace.
> 
> This is useful for running widgetexplorer in qmlscene.
> 
> This makes testing, debugging and profiling considerably easier.
> 
> 
> Diffs
> -----
> 
>   src/shell/CMakeLists.txt 17713a1 
>   src/shell/shellcorona.cpp 2870402 
>   src/shell/widgetexplorer/CMakeLists.txt PRE-CREATION 
>   src/shell/widgetexplorer/qmldir PRE-CREATION 
>   src/shell/widgetexplorer/widgetexplorerplugin.h PRE-CREATION 
>   src/shell/widgetexplorer/widgetexplorerplugin.cpp PRE-CREATION 
> 
> Diff: https://git.reviewboard.kde.org/r/114914/diff/
> 
> 
> Testing
> -------
> 
> Ran WidgetExplorer.qml in qmlscene. Also ran plasma-shell and confirmed that behaves as before.
> 
> 
> Thanks,
> 
> David Edmundson
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/plasma-devel/attachments/20140108/39b7bee1/attachment.html>