Review Request 114892: Plasma-mediacenter plays songs or videos: passed as arguments

[Shantanu Tushar]

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/114892/#review46992
-----------------------------------------------------------


Seems to work as expected, with a issue that the current playlist highlight is still at "Default" while the current playlist is actually "Misc", as seen at http://i.imgur.com/O09qzor.png


libs/mediacenter/playlistmodel.cpp
<https://git.reviewboard.kde.org/r/114892/#comment33525>

    this path is calculated at two places, one here and one on lines 203-204. Try sharing code between checkPlaylistPathExists() and playlistFilePath()



shells/newshell/mainwindow.cpp
<https://git.reviewboard.kde.org/r/114892/#comment33526>

    I am assuming you are using this to communicate between C++ and QML. If so, using Settings for it is a very bad idea. Set a context flag if absolutely necessary.


- Shantanu Tushar


On Jan. 7, 2014, 8:01 a.m., Sujith Haridasan wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.org/r/114892/
> -----------------------------------------------------------
> 
> (Updated Jan. 7, 2014, 8:01 a.m.)
> 
> 
> Review request for Plasma, Shantanu Tushar and Sinny Kumari.
> 
> 
> Repository: plasma-mediacenter
> 
> 
> Description
> -------
> 
> PMC can play songs from the command line or when selected from file browsers like Dolphin( using "Open With" ). PMC creates a separate playlist called "Misc" which will store the files which are tried to open from command line or so. Name given for the playlist is a temperory one ("Misc"). We can discuss here and rename it to something meaningful. I have tested this functionality and it works. 
> 
> 
> Diffs
> -----
> 
>   libs/mediacenter/playlistmodel.h 3993ac3 
>   libs/mediacenter/playlistmodel.cpp 00a0cee 
>   mediaelements/playlist/MultiplePlaylists.qml 42877f0 
>   shells/newshell/mainwindow.cpp b2793df 
> 
> Diff: https://git.reviewboard.kde.org/r/114892/diff/
> 
> 
> Testing
> -------
> 
> Open pmc from the command line (or from Dolphin) with multiple files to be opened:
> 1) PMC starts playing the songs/videos with the ones passed.
> With Dolphin I have tested with only one file and it worked properly.
> 
> 
> Thanks,
> 
> Sujith Haridasan
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/plasma-devel/attachments/20140107/76022a94/attachment.html>