Review Request 114886: Port Time dataengine to QTimeZone

John Layt jlayt at kde.org
Mon Jan 6 15:37:06 UTC 2014


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/114886/#review46915
-----------------------------------------------------------

Ship it!


Looks good to me (haven't tested it though).

- John Layt


On Jan. 6, 2014, 3:07 p.m., Martin Klapetek wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.org/r/114886/
> -----------------------------------------------------------
> 
> (Updated Jan. 6, 2014, 3:07 p.m.)
> 
> 
> Review request for Plasma and John Layt.
> 
> 
> Repository: kde-workspace
> 
> 
> Description
> -------
> 
> as $summary
> 
> 
> Diffs
> -----
> 
>   plasma/generic/dataengines/time/timeengine.cpp 0321b0e 
>   plasma/generic/dataengines/time/timesource.cpp 6651d56 
> 
> Diff: https://git.reviewboard.kde.org/r/114886/diff/
> 
> 
> Testing
> -------
> 
> Engine explorer shows correct values
> 
> 
> Thanks,
> 
> Martin Klapetek
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/plasma-devel/attachments/20140106/3e60144b/attachment.html>


More information about the Plasma-devel mailing list