Review Request 114589: Fix leaks in MouseEventListener

David Edmundson david at davidedmundson.co.uk
Fri Jan 3 18:25:07 UTC 2014


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/114589/
-----------------------------------------------------------

(Updated Jan. 3, 2014, 6:25 p.m.)


Status
------

This change has been marked as submitted.


Review request for Plasma.


Repository: plasma-framework


Description
-------


Fix memory issues in MouseEventListener

Delete KDeclarativeMouseEvent when emitted

Do not leak KDeclarativeMouseEvent press and hold events when the mouse
moves.

Do not create KDeclarativeMouseEvent when the mouse is hovered. It's
pointless.


Add documentation for MouseEventListener

Add a simple manual test for MouseEventListener


Diffs
-----

  src/declarativeimports/qtextracomponents/mouseeventlistener.h 7940846 
  src/declarativeimports/qtextracomponents/mouseeventlistener.cpp 8f925dd 
  src/declarativeimports/qtextracomponents/tests/mouseeventlistenertest.qml PRE-CREATION 

Diff: https://git.reviewboard.kde.org/r/114589/diff/


Testing
-------


Thanks,

David Edmundson

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/plasma-devel/attachments/20140103/d7dddb77/attachment.html>


More information about the Plasma-devel mailing list