Review Request 112445: Port EffectWatcher to XCB

[Martin Gräßlin]

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/112445/
-----------------------------------------------------------

(Updated Jan. 3, 2014, 9:06 a.m.)


Review request for Plasma and Marco Martin.


Changes
-------

rebased to latest state of master branch.


Repository: plasma-framework


Description
-------

Saves quite a lot of roundtrips to the XServer. Most important we
fetch the atom only once which means we don't have to refetch when
checking the property notify events.


Diffs (updated)
-----

  src/plasma/private/effectwatcher_p.h 626b1e6 
  src/plasma/private/effectwatcher.cpp 58ca942 
  src/plasma/CMakeLists.txt e34d888 

Diff: https://git.reviewboard.kde.org/r/112445/diff/


Testing
-------

It compiles. There's no unit test for it, so I cannot really test


Thanks,

Martin Gräßlin

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/plasma-devel/attachments/20140103/4026cc56/attachment-0001.html>