Review Request 114746: [calculator runner] Replace regexp with explicit character category check

[Christoph Feck]

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/114746/
-----------------------------------------------------------

(Updated Jan. 1, 2014, 5:03 p.m.)


Status
------

This change has been marked as submitted.


Review request for Plasma.


Bugs: 321803
    http://bugs.kde.org/show_bug.cgi?id=321803


Repository: kde-workspace


Description
-------

The current calculator krunner checks for textual input using a simple [a-zA-Z] regexp, which is going to fail for non-latin letters. Instead of increasing regexp complexity, I simply use the QChar category functions to check for letters.

Additionally, any input non consisting of at least a single digit requires the leading or trailing '=' sign, to avoid matches on pure symbol input, such as "(!)" or whatever.


Diffs
-----

  plasma/generic/runners/calculator/calculatorrunner.h 3a031e0 
  plasma/generic/runners/calculator/calculatorrunner.cpp 8d00449 

Diff: https://git.reviewboard.kde.org/r/114746/diff/


Testing
-------


Thanks,

Christoph Feck

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/plasma-devel/attachments/20140101/b2dc58f9/attachment.html>