Review Request 116460: Footer clock fix

Bhushan Shah bhush94 at gmail.com
Fri Feb 28 04:59:06 UTC 2014


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/116460/#review51289
-----------------------------------------------------------


However I am not sure why we have formatting logic in the application? Can't we use Qt.formatDateTime or others? @Shaan7 ?


mediaelements/mediawelcome/HomeScreenFooter.qml
<https://git.reviewboard.kde.org/r/116460/#comment36121>

    Remove White space here and at other parts. For future if you are using Kate,
    
    Set Settings > Configure Kate > Open/Save > Remove trailing spaces to on modified lines.


- Bhushan Shah


On Feb. 28, 2014, 2:42 a.m., Maulik Kotadia wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.org/r/116460/
> -----------------------------------------------------------
> 
> (Updated Feb. 28, 2014, 2:42 a.m.)
> 
> 
> Review request for Plasma, R.Harish  Navnit, Shantanu Tushar, and Sinny Kumari.
> 
> 
> Repository: plasma-mediacenter
> 
> 
> Description
> -------
> 
> The footer clock in PMC is set to 12Hr format and it was showing 0:00 AM instead of 12:00 AM 
> 
> 
> Diffs
> -----
> 
>   mediaelements/mediawelcome/HomeScreenFooter.qml d2c0eb7 
> 
> Diff: https://git.reviewboard.kde.org/r/116460/diff/
> 
> 
> Testing
> -------
> 
> I've tested the diff and its working correctly
> 
> 
> Thanks,
> 
> Maulik Kotadia
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/plasma-devel/attachments/20140228/968c5ab6/attachment.html>


More information about the Plasma-devel mailing list