Review Request 116024: Port IconItem to native QSGTexture
David Edmundson
david at davidedmundson.co.uk
Thu Feb 27 12:19:08 UTC 2014
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/116024/
-----------------------------------------------------------
(Updated Feb. 27, 2014, 12:19 p.m.)
Review request for Plasma.
Changes
-------
Perform the animation as a fragment shader.
I've done it as a separate class because I know Eike wants to fade between prefixes in FrameSVG.
Repository: plasma-framework
Description
-------
Port IconItem to native QSGTexture including the animation.
This will save constantly uploading a new texture to OpenGL throughout the animation.
Diffs (updated)
-----
CMakeLists.txt 4bc47bf
src/declarativeimports/core/CMakeLists.txt 97e9283
src/declarativeimports/core/fadingnode.cpp PRE-CREATION
src/declarativeimports/core/fadingnode_p.h PRE-CREATION
src/declarativeimports/core/iconitem.h 26ee410
src/declarativeimports/core/iconitem.cpp fed2f9b
Diff: https://git.reviewboard.kde.org/r/116024/diff/
Testing
-------
Test app: http://paste.kde.org/pl5pwdnel
Thanks,
David Edmundson
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/plasma-devel/attachments/20140227/9cbd329d/attachment.html>
More information about the Plasma-devel
mailing list