Review Request 116085: welcome back the javascript interactive console

[Marco Martin]

> On Feb. 26, 2014, 3:47 p.m., David Edmundson wrote:
> > src/shell/interactiveconsole.cpp, line 57
> > <https://git.reviewboard.kde.org/r/116085/diff/1/?file=246320#file246320line57>
> >
> >     Are you not doing that on line 130?

yeah, comes from the copy of the oold file ;)


> On Feb. 26, 2014, 3:47 p.m., David Edmundson wrote:
> > src/shell/interactiveconsole.h, line 2
> > <https://git.reviewboard.kde.org/r/116085/diff/1/?file=246319#file246319line2>
> >
> >     Is this copied from somewhere then?
> >     Update copyright if you need to, otherwise ignore this.

yeah, i tought about it after sending the rr, it comes from the plasma1 implementation, is just the same file adapted


- Marco


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/116085/#review50941
-----------------------------------------------------------


On Feb. 26, 2014, 3:25 p.m., Marco Martin wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.org/r/116085/
> -----------------------------------------------------------
> 
> (Updated Feb. 26, 2014, 3:25 p.m.)
> 
> 
> Review request for Plasma.
> 
> 
> Repository: plasma-framework
> 
> 
> Description
> -------
> 
> this ports the js interactive console from plasma1 and ports it way from kde4support
> 
> ui-wise it should look the same
> 
> 
> Diffs
> -----
> 
>   src/shell/scripting/scriptengine.cpp 29735a0 
>   src/shell/shellcorona.cpp e84e0bf 
>   src/shell/shellpluginloader.cpp c57b348 
>   src/shell/CMakeLists.txt db0e569 
>   src/shell/interactiveconsole.h PRE-CREATION 
>   src/shell/interactiveconsole.cpp PRE-CREATION 
>   src/shell/packages.h 999b4c9 
>   src/shell/packages.cpp 0b2aa3f 
>   src/shell/scripting/layouttemplatepackagestructure.h abc5562 
>   src/shell/scripting/layouttemplatepackagestructure.cpp bc1d0ca 
> 
> Diff: https://git.reviewboard.kde.org/r/116085/diff/
> 
> 
> Testing
> -------
> 
> tried to add plasmoids from the console
> 
> 
> Thanks,
> 
> Marco Martin
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/plasma-devel/attachments/20140226/0921c7e7/attachment.html>