Review Request 115990: Follow Qt's OpenGL compile flags

Marco Martin notmart at gmail.com
Mon Feb 24 09:35:04 UTC 2014


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/115990/#review50639
-----------------------------------------------------------

Ship it!


Ship It!

- Marco Martin


On Feb. 24, 2014, 8:45 a.m., Martin Gräßlin wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.org/r/115990/
> -----------------------------------------------------------
> 
> (Updated Feb. 24, 2014, 8:45 a.m.)
> 
> 
> Review request for Plasma.
> 
> 
> Repository: plasma-framework
> 
> 
> Description
> -------
> 
> Follow Qt's OpenGL compile flags
> 
> Only link against OpenGL if Qt links against OpenGL. This ensures
> that we don't run into issues if Qt links GLES and plasma links
> GL because that's found.
> 
> 
> Diffs
> -----
> 
>   CMakeLists.txt a1b39f09540984307ca1a6ad02aa388a0f3207ba 
>   src/declarativeimports/core/CMakeLists.txt dadd350f54972b7f3d56b1d4b931373a3f3e2696 
> 
> Diff: https://git.reviewboard.kde.org/r/115990/diff/
> 
> 
> Testing
> -------
> 
> 
> Thanks,
> 
> Martin Gräßlin
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/plasma-devel/attachments/20140224/88090172/attachment.html>


More information about the Plasma-devel mailing list