Review Request 115923: Render SvgItem natively rather than going through QQuickPaintedItem

[David Edmundson]

> On Feb. 20, 2014, 7:54 p.m., Marco Martin wrote:
> > src/declarativeimports/core/svgitem.cpp, line 138
> > <https://git.reviewboard.kde.org/r/115923/diff/1/?file=245131#file245131line138>
> >
> >     is this guaranteed to be always deleted?

I believe so.

There's a flag on QGSNode QSGNode::OwnedByParent
this is set by default.

The QQuickItem documentation example and tests appear to be the same.


> On Feb. 20, 2014, 7:54 p.m., Marco Martin wrote:
> > src/plasma/svg.h, line 109
> > <https://git.reviewboard.kde.org/r/115923/diff/1/?file=245132#file245132line109>
> >
> >     this doesn't seem to do a much useful thing?

It's a convenient wrapper round svg->pixmap().toImage();

Given I'm going to use it from more places, it seems like it'll keep things neater. It will also allows me to add things I need for the rest of porting without breaking the current API everyone else is using.

For my FrameSVG stuff, I need to pass a QSize here.


- David


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/115923/#review50401
-----------------------------------------------------------


On Feb. 20, 2014, 7:22 p.m., David Edmundson wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.org/r/115923/
> -----------------------------------------------------------
> 
> (Updated Feb. 20, 2014, 7:22 p.m.)
> 
> 
> Review request for Plasma.
> 
> 
> Repository: plasma-framework
> 
> 
> Description
> -------
> 
> The rationale behind this patch is on the mailing list in the thread "Minutes Monday" 
> 
> This doesn't boost performance or save memory much, but it paves the way for texture sharing, faster resizing, and plenty of other things.
> 
> Based on Frederick's comment I have reverted my changes to use QImage everywhere, otherwise we lose out on the local QPixmap cache in KImageCache.
> Changes to plasmacore are minimal.
> 
> I'm currently porting FrameSVG which is where we should see more gains, but I thought I should get this reviewed/merged in parallel.
> 
> I have only seen one regression which is in the analog clock.
> Some odd code in the analog clock (by me apparently!) means the width is dependent on the current width, which due to some changes in this patch ends up in a constant spiral getting to infinitely sized and explode.  
> 
> 
> Changelog (in reverse order):
> Remove manual isDirty tracking in SvgItem
> Always resize the node geometry on resizes
> Update to paint to fill the size of the object, not the size of texture
> Fix leaking texture
> Add convenient QImage image() getter in SVG
> Avoid repainting if node is not changed
> Render SvgItem natively rather than going through QQuickPaintedItem
> 
> 
> Diffs
> -----
> 
>   src/declarativeimports/core/svgitem.h c8be7cc 
>   src/declarativeimports/core/svgitem.cpp e90751a 
>   src/plasma/svg.h 01d98f8 
>   src/plasma/svg.cpp 9ec2aa5 
> 
> Diff: https://git.reviewboard.kde.org/r/115923/diff/
> 
> 
> Testing
> -------
> 
> 
> Thanks,
> 
> David Edmundson
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/plasma-devel/attachments/20140220/81f60cdf/attachment.html>