Review Request 114493: Plasmate: Merge plasmoidviewer2 branch into frameworks

[Sebastian Kügler]

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/114493/#review50384
-----------------------------------------------------------

Ship it!


I've found a few more smallish problems. Please address those, and then feel free to merge it.


plasmoidviewer/CMakeLists.txt
<https://git.reviewboard.kde.org/r/114493/#comment35435>

    org.kde.plasma.plasmoidviewer (we put everything under org.kde.plasma)



plasmoidviewer/qmlpackages/shell/contents/views/SdkButtons.qml
<https://git.reviewboard.kde.org/r/114493/#comment35438>

    Should be BottomEdge, not Bottomedge



plasmoidviewer/qmlpackages/shell/contents/views/SdkButtons.qml
<https://git.reviewboard.kde.org/r/114493/#comment35437>

    there's a trailing t at the end which doesn't belong here.



plasmoidviewer/view.cpp
<https://git.reviewboard.kde.org/r/114493/#comment35439>

    i18n (we do it for other console output as well)



plasmoidviewer/view.cpp
<https://git.reviewboard.kde.org/r/114493/#comment35440>

    i18n (we do it for other console output as well)


- Sebastian Kügler


On Feb. 20, 2014, 4:19 p.m., Antonis Tsiapaliokas wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.org/r/114493/
> -----------------------------------------------------------
> 
> (Updated Feb. 20, 2014, 4:19 p.m.)
> 
> 
> Review request for Plasma.
> 
> 
> Repository: plasmate
> 
> 
> Description
> -------
> 
> This is a merge request for plasmoidviewer2 branch into the frameworks branch.
> 
> Plasmoidviewer2 branch contains some missing features and bug fixes.
> 
> 
> Diffs
> -----
> 
>   plasmoidviewer/qmlpackages/containment/contents/ui/main.qml 6558710 
>   plasmoidviewer/qmlpackages/containment/metadata.desktop 9ddd217 
>   plasmoidviewer/qmlpackages/shell/contents/views/Background.qml PRE-CREATION 
>   plasmoidviewer/qmlpackages/shell/contents/views/Desktop.qml e5bedf3 
>   plasmoidviewer/qmlpackages/shell/contents/views/Konsole.qml PRE-CREATION 
>   plasmoidviewer/qmlpackages/shell/contents/views/SdkButtons.qml PRE-CREATION 
>   plasmoidviewer/view.h 4cc472b 
>   plasmoidviewer/view.cpp 511fe66 
>   plasmoidviewer/qmlpackages/containment/contents/ui/AppletAppearance.qml b23e098 
>   plasmoidviewer/qmlpackages/containment/contents/ui/BusyOverlay.qml 33d72c0 
>   plasmoidviewer/CMakeLists.txt 30de8e2 
>   plasmoidviewer/fullview.h 7d4c70d 
>   plasmoidviewer/fullview.cpp 898931a 
>   plasmoidviewer/main.cpp 9b41e78 
>   plasmoidviewer/qmlpackages/containment/Messages.sh c8a9b60 
>   plasmoidviewer/qmlpackages/containment/contents/code/LayoutManager.js 62e149a 
>   plasmoidviewer/qmlpackages/containment/contents/config/main.xml d889999 
> 
> Diff: https://git.reviewboard.kde.org/r/114493/diff/
> 
> 
> Testing
> -------
> 
> 
> Thanks,
> 
> Antonis Tsiapaliokas
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/plasma-devel/attachments/20140220/3557b753/attachment-0001.html>