Review Request 115910: Screenedge show support for Clients

[Martin Gräßlin]

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/115910/
-----------------------------------------------------------

Review request for kwin and Plasma.


Repository: kde-workspace


Description
-------

Screenedge show support for Clients

This provides a new protocol intended to be used by auto-hiding panels
to make use of the centralized screen edges. To use it a Client can
send a client message of type _KDE_NET_WM_SCREEN_EDGE_SHOW to KWin.
KWin will hide the Client (hide because unmap or minimize would break
it) and create an Edge. If that Edge gets triggered the Client is shown
again. If the Client doesn't border a screen edge the Client gets shown
immediately so that we never end in a situation that we cannot unhide
the auto-hidden panel again. The exact process is described in the
documentation of ScreenEdges.

If KWin gets restarted the Client gets shown again.

As this is a KWin specific extension we need to discuss what it means
for Clients using this feature with other WMs: it does nothing. As
the Client gets hidden by KWin and not by the Client, it just doesn't
get hidden if the WM doesn't provide the feature. In case of an
auto-hiding panel this seems like a good solution given that we don't
want to hide it if we cannot unhide it. Of course there's the option
for the Client to provide that feature itself and if that's wanted we
would need to announce the feature in the _NET_SUPPORTED atom. At the
moment that doesn't sound like being needed as Plasma doesn't want to
provide an own implementation.

The implementation comes with a small test application showing how
the feature is intended to be used.


Diffs
-----

  kwin/atoms.h 1690067c5d1da59f38f9e77ef64eacfbc1faa0cf 
  kwin/atoms.cpp 904f5efe4a32e3673dae9e6da92bf4336def660d 
  kwin/client.cpp 36431bfc33418a207de12fa8cc95a35539256366 
  kwin/events.cpp 1fa6e425d4dac7d661612e5d090c3c9c8f4b1a18 
  kwin/screenedge.h 60f5fd669ccc5eb627feffa460552558d1765b31 
  kwin/screenedge.cpp 04cf0d6d5262ab84d88559b6dc85e099efec77bf 
  kwin/tests/CMakeLists.txt 3fa16f21c617a8f4b39b2bbd39b534b6a11e8d14 
  kwin/tests/screenedgeshowtest.cpp PRE-CREATION 

Diff: https://git.reviewboard.kde.org/r/115910/diff/


Testing
-------


Thanks,

Martin Gräßlin

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/plasma-devel/attachments/20140220/2523d9bb/attachment-0001.html>