Review Request 115902: Force backgroundcontrast during slidingpopup animations

[Martin Gräßlin]

> On Feb. 20, 2014, 7:33 a.m., Martin Gräßlin wrote:
> > kwin/effects/slidingpopups/slidingpopups.cpp, line 295
> > <https://git.reviewboard.kde.org/r/115902/diff/2/?file=244989#file244989line295>
> >
> >     are you sure you want to remove them in the slotWindowClosed? That sounds like you want to do that in slotWindowDeleted
> 
> Sebastian Kügler wrote:
>     m_backgroundContrastForced is only used for appearing windows (we don't need to reset the flag when the window is getting deleted next, anyway). As soon as a window gets windowClosed, we now the flag won't be needed to be reset anymore, so I'm clearing the window from the list there already.

you lost me here. Why do you only want to do the force in the appearig animation but ot in the closing animation?


- Martin


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/115902/#review50300
-----------------------------------------------------------


On Feb. 20, 2014, 2:28 a.m., Sebastian Kügler wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.org/r/115902/
> -----------------------------------------------------------
> 
> (Updated Feb. 20, 2014, 2:28 a.m.)
> 
> 
> Review request for kwin and Plasma.
> 
> 
> Repository: kde-workspace
> 
> 
> Description
> -------
> 
> Force backgroundcontrast during slidingpopup animations
> 
> This fixes the sliding popups losing their contrast effect when
> animating, less flicker.
> 
> In this patch, we temporarily force the contrast effect on, but only if
> it hasn't been explicitely disabled. As soon as the animation stops, the
> force flag is disabled again. For disappearing windows, we just set the
> flag in the same way, but skip over the bookkeeping, since the window is
> going to be deleted, anyway.
> 
> 
> Diffs
> -----
> 
>   kwin/effects/slidingpopups/slidingpopups.h f66e42e 
>   kwin/effects/slidingpopups/slidingpopups.cpp 4f0a9ea 
> 
> Diff: https://git.reviewboard.kde.org/r/115902/diff/
> 
> 
> Testing
> -------
> 
> Slowed down effects, made sure the contrast effect is applied correctly, made sure the bookkeeping is OK. No visible side-effects observed.
> 
> 
> Thanks,
> 
> Sebastian Kügler
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/plasma-devel/attachments/20140220/f53a3171/attachment.html>