Review Request 115857: Fix flickering of sliding popups while disappearing

Sebastian Kügler sebas at kde.org
Wed Feb 19 13:10:07 UTC 2014


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/115857/
-----------------------------------------------------------

(Updated Feb. 19, 2014, 1:10 p.m.)


Status
------

This change has been marked as submitted.


Review request for kwin and Plasma.


Repository: kde-workspace


Description
-------

Fix flickering of sliding popups while disappearing

The last frame was fully painted for Plasma 2 panel popups, as it's
repainted in full on the last frame (without opacity and position
transformations applied).

Removing the repaint on this last frame makes the popups disappear
smoothly for me, without other side-effects such as artifacts on the
screen or other repaint problems.


Diffs
-----

  kwin/effects/slidingpopups/slidingpopups.cpp fd697f0c62e9099d4be71e1f9d99e64ecb5ff663 

Diff: https://git.reviewboard.kde.org/r/115857/diff/


Testing
-------

Ran kwin with this on Intel driver, flickering is gone in Plasma 2 and Yakuake 4.x.


Thanks,

Sebastian Kügler

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/plasma-devel/attachments/20140219/546c2d1e/attachment.html>


More information about the Plasma-devel mailing list