Review Request 115871: Use QStandardPaths for finding plasma shells instead of hardcoding to install prefix

Ivan Čukić ivan.cukic at kde.org
Wed Feb 19 09:50:08 UTC 2014


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/115871/#review50196
-----------------------------------------------------------

Ship it!


Looks ok to me

- Ivan Čukić


On Feb. 18, 2014, 5:40 p.m., Hrvoje Senjan wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.org/r/115871/
> -----------------------------------------------------------
> 
> (Updated Feb. 18, 2014, 5:40 p.m.)
> 
> 
> Review request for Plasma, Ivan Čukić and Sebastian Kügler.
> 
> 
> Bugs: 331063
>     http://bugs.kde.org/show_bug.cgi?id=331063
> 
> 
> Repository: plasma-framework
> 
> 
> Description
> -------
> 
> as summarized. otherwise the referenced bug comes up.
> 
> 
> Diffs
> -----
> 
>   src/shell/shellmanager.cpp 1188b48 
> 
> Diff: https://git.reviewboard.kde.org/r/115871/diff/
> 
> 
> Testing
> -------
> 
> builds & plasma runs with plasma-framework installed to /usr, and kde-workspace to /opt.
> 
> 
> Thanks,
> 
> Hrvoje Senjan
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/plasma-devel/attachments/20140219/8adfad4a/attachment.html>


More information about the Plasma-devel mailing list