Review Request 115859: Force-allow background contrast while sliding desktops

[Sebastian Kügler]

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/115859/
-----------------------------------------------------------

(Updated Feb. 19, 2014, 12:33 a.m.)


Review request for kwin and Plasma.


Changes
-------

New approach that keeps the hot paths untouched.

- set forced background on relevant windows before the slide starts
- when a window is added during the slide, it's checked, and possibly get the same treatment
- when the effect stops or is interupted, we clean up and reset the flags

This should address all open issues.


Repository: kde-workspace


Description
-------

Force-allow background contrast while sliding

When the sliding effect is active, the background blur of the panel
would be disabled unless forced with WindowForceBackgroundContrastRole,
which is actually what we want: during sliding, the backgroundcontrast
effect would otherwise be disabled, leading to the panel and popups
flickering between contrast enabled and disabled.

With this patch, the panel keeps its coloring during desktop changes.


Diffs (updated)
-----

  kwin/effects/slide/slide.h c8e0a84 
  kwin/effects/slide/slide.cpp 8ecb2a6 
  kwin/effects/slidingpopups/slidingpopups.cpp fd697f0 

Diff: https://git.reviewboard.kde.org/r/115859/diff/


Testing
-------

Switched desktops, panel keeps color, fullscreen video player doesn't seem to be affected negatively, everything still works as expected, except that the flickering in Plasma Dialogs is gone.


Thanks,

Sebastian Kügler

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/plasma-devel/attachments/20140219/2310b967/attachment.html>