Review Request 115859: Force-allow background contrast while sliding desktops

[Martin Gräßlin]

> On Feb. 18, 2014, 3:06 p.m., Martin Gräßlin wrote:
> > kwin/effects/slide/slide.h, line 43
> > <https://git.reviewboard.kde.org/r/115859/diff/3/?file=244773#file244773line43>
> >
> >     please add override and you can remove the virtual in that case
> 
> Sebastian Kügler wrote:
>     This should be done for all the virtual methods in there, right?

yesno. With an infinite amount of time: yes, otherwise I don't see a good reason to adjust existing code. We just should make sure to use the new stuff for new code.


- Martin


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/115859/#review50145
-----------------------------------------------------------


On Feb. 18, 2014, 4:46 p.m., Sebastian Kügler wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.org/r/115859/
> -----------------------------------------------------------
> 
> (Updated Feb. 18, 2014, 4:46 p.m.)
> 
> 
> Review request for kwin and Plasma.
> 
> 
> Repository: kde-workspace
> 
> 
> Description
> -------
> 
> Force-allow background contrast while sliding
> 
> When the sliding effect is active, the background blur of the panel
> would be disabled unless forced with WindowForceBackgroundContrastRole,
> which is actually what we want: during sliding, the backgroundcontrast
> effect would otherwise be disabled, leading to the panel and popups
> flickering between contrast enabled and disabled.
> 
> With this patch, the panel keeps its coloring during desktop changes.
> 
> 
> Diffs
> -----
> 
>   kwin/effects/slidingpopups/slidingpopups.cpp fd697f0 
>   kwin/effects/slide/slide.cpp 8ecb2a6 
>   kwin/effects/slide/slide.h c8e0a84 
> 
> Diff: https://git.reviewboard.kde.org/r/115859/diff/
> 
> 
> Testing
> -------
> 
> Switched desktops, panel keeps color, fullscreen video player doesn't seem to be affected negatively, everything still works as expected, except that the flickering in Plasma Dialogs is gone.
> 
> 
> Thanks,
> 
> Sebastian Kügler
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/plasma-devel/attachments/20140218/84234983/attachment.html>