Review Request 115830: Remove unused system dependencies
Sebastian Kügler
sebas at kde.org
Mon Feb 17 16:05:45 UTC 2014
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/115830/#review50059
-----------------------------------------------------------
Ship it!
Looks sane, thanks! I think most of those includes are actually just ported over from kdelibs, I didn't check feature-by-feature when the dependency exactly go.
- Sebastian Kügler
On Feb. 17, 2014, 3:42 p.m., Michael Palimaka wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.org/r/115830/
> -----------------------------------------------------------
>
> (Updated Feb. 17, 2014, 3:42 p.m.)
>
>
> Review request for Plasma.
>
>
> Repository: plasma-framework
>
>
> Description
> -------
>
> - plasma_appletscript_declarative includes QtUiTools but doesn't use it
> - QtPrintSupport is not used anywhere
> - Xss, Xext, and SM are not used anywhere
> - OpenSSL is not used anywhere
>
>
> Diffs
> -----
>
> CMakeLists.txt e80978e680f0dd6230bd8e4c275fa356a0abbd5a
> src/plasma/CMakeLists.txt ef886c82bde3aa5398d1ae01634bdc0c206c6ac4
> src/scriptengines/qml/CMakeLists.txt 5c121dd99d691f510172e438b718e2ed34ac53d1
> src/scriptengines/qml/plasmoid/declarativeappletscript.cpp ab9cd856d1788df8068f7a4bdc32ff96daf22559
>
> Diff: https://git.reviewboard.kde.org/r/115830/diff/
>
>
> Testing
> -------
>
> Builds. Tests pass.
>
>
> Thanks,
>
> Michael Palimaka
>
>
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/plasma-devel/attachments/20140217/476ae834/attachment.html>
More information about the Plasma-devel
mailing list