Review Request 115409: Workaround battery detection at runtime

Sebastian Kügler sebas at kde.org
Sat Feb 15 22:02:44 UTC 2014


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/115409/#review49877
-----------------------------------------------------------

Ship it!


I've recently debugged a similar issue in Plasma Next. There, the event seems to arrive just fine, but the plasmoid.status was never updated. Just calling it once helped the problem, but I wasn't able to figure out why. I don't see anything special happening when calling plasmoid.status, other than it's harmless and makes the battery appear reliably. That's 2c18797012 in kdeworkspace[master].

I've tried the same in 4.x, but it didn't work. Since your patch won't make it into Plasma Next, I think I can live with the expense of this hack you propose, compared to its benefits (i.e. it makes things work for our users).

- Sebastian Kügler


On Feb. 15, 2014, 4:58 p.m., Kai Uwe Broulik wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.org/r/115409/
> -----------------------------------------------------------
> 
> (Updated Feb. 15, 2014, 4:58 p.m.)
> 
> 
> Review request for Plasma, Solid and Sebastian Kügler.
> 
> 
> Bugs: 324847
>     http://bugs.kde.org/show_bug.cgi?id=324847
> 
> 
> Repository: kde-workspace
> 
> 
> Description
> -------
> 
> For some reason when a new battery appears (eg. mouse plugged in), the battery does not appear right away in the battery monitor. It appears instantly in plasmaengineexplorer, however.
> I am really clueless on to what causes this, so I just throw this patch in for enlightenment as it sort of makes it work. :/
> 
> 
> Diffs
> -----
> 
>   plasma/generic/applets/batterymonitor/contents/ui/batterymonitor.qml c1c0169 
> 
> Diff: https://git.reviewboard.kde.org/r/115409/diff/
> 
> 
> Testing
> -------
> 
> Has some minor glitches, please see bugreport.
> 
> 
> Thanks,
> 
> Kai Uwe Broulik
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/plasma-devel/attachments/20140215/8725dd01/attachment-0001.html>


More information about the Plasma-devel mailing list