Review Request 115712: Do not show OSD for invalid percentage i.e -1 or 109

[Bhushan Shah]

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/115712/
-----------------------------------------------------------

(Updated Feb. 13, 2014, 12:38 p.m.)


Review request for Plasma and Martin Klapetek.


Repository: plasma-framework


Description
-------

$summary

Actually this will never happen as OSD will be triggered by applications only but better to check it.


Diffs (updated)
-----

  src/shell/osd.cpp e94d225 

Diff: https://git.reviewboard.kde.org/r/115712/diff/


Testing
-------

qdbus org.kde.plasma_shell /org/kde/osdService org.kde.osdService.volumeChanged 203
qdbus org.kde.plasma_shell /org/kde/osdService org.kde.osdService.volumeChanged -40

OSD does not show up


Thanks,

Bhushan Shah

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/plasma-devel/attachments/20140213/da4c634a/attachment.html>