Review Request 115641: Ensure to not call X11 specific calls if we are not on platform X11

Sebastian Kügler sebas at kde.org
Wed Feb 12 13:20:33 UTC 2014


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/115641/#review49652
-----------------------------------------------------------

Ship it!


Ship It!

- Sebastian Kügler


On Feb. 11, 2014, 7:54 a.m., Martin Gräßlin wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.org/r/115641/
> -----------------------------------------------------------
> 
> (Updated Feb. 11, 2014, 7:54 a.m.)
> 
> 
> Review request for Plasma.
> 
> 
> Repository: plasma-framework
> 
> 
> Description
> -------
> 
> Ensure to not call X11 specific calls if we are not on platform X11
> 
> This fixes a bunch of possible crashy code when trying to run
> applications linking plasma-framework on platform Wayland.
> 
> 
> Diffs
> -----
> 
>   src/declarativeimports/core/dialogshadows.cpp 5a0ee82576e61430a1e7a330a5ad973ef75067c9 
>   src/plasma/private/effectwatcher.cpp 495fa5986817fe325a3aea349980fb9e627a6fa7 
>   src/plasma/private/effectwatcher_p.h 386a839bc3c31ae53a2bae5c382ec00f0dad3ef6 
>   src/shell/panelshadows.cpp d2fa85bb8644d0d610e69c26c0fad7828868d277 
> 
> Diff: https://git.reviewboard.kde.org/r/115641/diff/
> 
> 
> Testing
> -------
> 
> kwin-compositing-kcm no longer crashes when started on Wayland
> 
> 
> Thanks,
> 
> Martin Gräßlin
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/plasma-devel/attachments/20140212/e97baacd/attachment.html>


More information about the Plasma-devel mailing list