Review Request 115643: Fix X11 usage in the pager

Sebastian Kügler sebas at kde.org
Tue Feb 11 09:09:26 UTC 2014


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/115643/#review49516
-----------------------------------------------------------

Ship it!


Go, Martin!


plasma/desktop/applets/pager/plugin/pager.cpp
<https://git.reviewboard.kde.org/r/115643/#comment34918>

    ws


- Sebastian Kügler


On Feb. 11, 2014, 8:38 a.m., Martin Gräßlin wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.org/r/115643/
> -----------------------------------------------------------
> 
> (Updated Feb. 11, 2014, 8:38 a.m.)
> 
> 
> Review request for Plasma.
> 
> 
> Repository: kde-workspace
> 
> 
> Description
> -------
> 
> Fix X11 usage in the pager
> 
> It was not yet completely ported and still used Q_WS_X11. This
> is changed to HAVE_X11 and a few X11 specific calls are wrapped
> in ifdefs as well as runtime detection is added.
> 
> 
> Diffs
> -----
> 
>   plasma/desktop/applets/pager/plugin/pager.h c85c2e908697098c7f8d777581f6e6ac0253430a 
>   plasma/desktop/applets/pager/plugin/pager.cpp c8c7bbdb9af523c4507c6efc9e6005d083da8603 
> 
> Diff: https://git.reviewboard.kde.org/r/115643/diff/
> 
> 
> Testing
> -------
> 
> pager no longer crashes on Wayland
> 
> 
> Thanks,
> 
> Martin Gräßlin
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/plasma-devel/attachments/20140211/0d98c4de/attachment.html>


More information about the Plasma-devel mailing list