Review Request 115536: Add window thumbnail to taskmanager

Kai Uwe Broulik kde at privat.broulik.de
Mon Feb 10 07:50:07 UTC 2014



> On Feb. 7, 2014, 11:47 p.m., Eike Hein wrote:
> > Sorry, I missed this yesterday due to an incorrect sieve filter.
> > 
> > As Mark points out the thumbnail sizes will have to be made DPI-aware (there's an outstanding user wish for that), but it can go in this way for now. I'm merging a series of address-loose-ends changes into the Task Manager this weekend that includes similar sizing work; I'll take a look at it as part of that.
> > 
> > Thanks!
> 
> Martin Gräßlin wrote:
>     If I had an idea how to get them properly scaled for high-dpi I'd do it myself :-)
> 
> Kai Uwe Broulik wrote:
>     regularThumbSize * QApplication::desktop()->physicalDpiX() / (qreal)96;
>

Or PlasmaCore.Units iirc


- Kai Uwe


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/115536/#review49228
-----------------------------------------------------------


On Feb. 10, 2014, 7:29 a.m., Martin Gräßlin wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.org/r/115536/
> -----------------------------------------------------------
> 
> (Updated Feb. 10, 2014, 7:29 a.m.)
> 
> 
> Review request for Plasma and Eike Hein.
> 
> 
> Repository: kde-workspace
> 
> 
> Description
> -------
> 
> Add window thumbnail to taskmanager
> 
> It forks the DefaultToolTip qml and adds the window thumbnails.
> 
> It's not yet working perfectly and I would like to have our QML
> experts have a look at it and give it a try.
> 
> 
> Diffs
> -----
> 
>   plasma/desktop/applets/taskmanager/package/contents/ui/Task.qml 11e80db26c6de14a8a1f0c0fedfd48dc1ffaef5e 
>   plasma/desktop/applets/taskmanager/package/contents/ui/ToolTipDelegate.qml PRE-CREATION 
>   plasma/desktop/applets/taskmanager/package/contents/ui/main.qml d590ec904d91beb1f3063b14d4e98596882ea365 
> 
> Diff: https://git.reviewboard.kde.org/r/115536/diff/
> 
> 
> Testing
> -------
> 
> 
> Thanks,
> 
> Martin Gräßlin
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/plasma-devel/attachments/20140210/63e4c980/attachment.html>


More information about the Plasma-devel mailing list